Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noexcept from UserPanicHandler::call() so that panic handlers can throw as documented #8390

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Remove noexcept from UserPanicHandler::call() so that panic handlers can throw as documented #8390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/utils/src/Panic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class UserPanicHandler {
struct CallBack {
Panic::PanicHandlerCallback handler = nullptr;
void* user = nullptr;
void call(Panic const& panic) const noexcept {
void call(Panic const& panic) const {
if (UTILS_UNLIKELY(handler)) {
handler(user, panic);
}
Expand All @@ -64,7 +64,7 @@ class UserPanicHandler {
return data;
}

void call(Panic const& panic) const noexcept {
void call(Panic const& panic) const {
getCallback().call(panic);
}

Expand Down