New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify yet more `instanceof`s, notably: #4771

Closed

copybara-service wants to merge 0 commits into master from test_716214531

Contributor

copybara-service bot commented Jan 16, 2025

Simplify yet more instanceofs, notably:

inverted conditions (especially with a definite return inside the then, which is common
casts within an expression, e.g. foo instanceof Bar && ((Bar) foo).frob().

I did a pile of extra simplification. You end up with a lot of redundant variables.

copybara-service bot closed this

copybara-service bot force-pushed the test_716214531 branch from b4940f3 to 249c359 Compare

January 16, 2025 16:58

copybara-service bot deleted the test_716214531 branch

January 16, 2025 16:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet