Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a unit test for an @Provides annotated method where the return type is the same as the param type. #3751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a unit test for an @Provides annotated method where the return type is the same as the param type. #3751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...com/google/errorprone/bugpatterns/checkreturnvalue/CanIgnoreReturnValueSuggesterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,4 +830,21 @@ public void providesMethod_b267362954() {
.expectUnchanged()
.doTest();
}

@Test
public void providesWithoutChangingType_b267463718() {
helper
.addInputLines(
"ExampleModule.java",
"package com.google.frobber;",
"public final class ExampleModule {",
" @com.google.inject.Provides",
" boolean provideEnableNewRiskAssignment(boolean enableNewRiskAssignment) {",
" return enableNewRiskAssignment;",
" }",
"}")
// we don't fire because @Provides is @Keep
.expectUnchanged()
.doTest();
}
}