Don't flag explicit record constructors as missing overrides.

Fixes external #4598. PiperOrigin-RevId: 683102994
google · Oct 7, 2024 · 81ae61d · 81ae61d
1 parent a241d95
commit 81ae61d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/MissingOverride.java b/core/src/main/java/com/google/errorprone/bugpatterns/MissingOverride.java
@@ -67,6 +67,7 @@ public Description matchMethod(MethodTree tree, VisitorState state) {
       return NO_MATCH;
     }
     if (ASTHelpers.isRecord(sym.owner)
+        && !sym.isConstructor()
         && sym.getModifiers().contains(Modifier.PUBLIC)
         && sym.getParameters().isEmpty()) {
       ImmutableSet<Name> components =

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/MissingOverrideTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/MissingOverrideTest.java
@@ -216,4 +216,23 @@ public int y() {
             """)
         .doTest();
   }
+
+  @Test
+  public void explicitRecordAccessor_doesNotFlagConstructors() {
+    assume().that(Runtime.version().feature()).isAtLeast(16);
+
+    compilationHelper
+        .addSourceLines(
+            "Test.java",
+            """
+            public record Test(int x) {
+              public Test() {
+                this(1);
+              }
+
+              public Test {}
+            }
+            """)
+        .doTest();
+  }
 }