Turn down DivZero.

It's aiming to replicate a javac warning, which I think we enable as an error anyway? PiperOrigin-RevId: 443055423
google · Apr 20, 2022 · 5361233 · 5361233
1 parent f174a80
commit 5361233
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 239 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/DivZero.java b/core/src/main/java/com/google/errorprone/bugpatterns/DivZero.java
diff --git a/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java b/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java
@@ -101,7 +101,6 @@
 import com.google.errorprone.bugpatterns.DifferentNameButSame;
 import com.google.errorprone.bugpatterns.DiscardedPostfixExpression;
 import com.google.errorprone.bugpatterns.DistinctVarargsChecker;
-import com.google.errorprone.bugpatterns.DivZero;
 import com.google.errorprone.bugpatterns.DoNotCallChecker;
 import com.google.errorprone.bugpatterns.DoNotCallSuggester;
 import com.google.errorprone.bugpatterns.DoNotClaimAnnotations;
@@ -1016,7 +1015,6 @@ public static ScannerSupplier errorChecks() {
           DeduplicateConstants.class,
           DepAnn.class,
           DifferentNameButSame.class,
-          DivZero.class,
           EmptyIfStatement.class,
           EmptyTopLevelDeclaration.class,
           EqualsBrokenForNull.class,

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/DivZeroTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/DivZeroTest.java
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DivZeroNegativeCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DivZeroNegativeCases.java
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DivZeroPositiveCases.java b/core/src/test/java/com/google/errorprone/bugpatterns/testdata/DivZeroPositiveCases.java
diff --git a/core/src/test/java/com/google/errorprone/scanner/ScannerSupplierTest.java b/core/src/test/java/com/google/errorprone/scanner/ScannerSupplierTest.java
@@ -44,9 +44,9 @@
 import com.google.errorprone.bugpatterns.BugChecker;
 import com.google.errorprone.bugpatterns.ChainingConstructorIgnoresParameter;
 import com.google.errorprone.bugpatterns.DepAnn;
-import com.google.errorprone.bugpatterns.DivZero;
 import com.google.errorprone.bugpatterns.EqualsIncompatibleType;
 import com.google.errorprone.bugpatterns.LongLiteralLowerCaseSuffix;
+import com.google.errorprone.bugpatterns.MethodCanBeStatic;
 import com.google.errorprone.bugpatterns.PackageLocation;
 import com.google.errorprone.bugpatterns.ReferenceEquality;
 import com.google.errorprone.bugpatterns.StaticQualifiedUsingExpression;
@@ -325,7 +325,9 @@ public void applyOverridesEnableAllChecks() {
     // The 'AllDisabledChecksAsWarnings' flag doesn't populate through to additional plugins
     assertScanner(
             ss.applyOverrides(epOptions)
-                .plus(ScannerSupplier.fromBugCheckerClasses(DivZero.class).filter(t -> false)))
+                .plus(
+                    ScannerSupplier.fromBugCheckerClasses(MethodCanBeStatic.class)
+                        .filter(t -> false)))
         .hasEnabledChecks(BadShiftAmount.class, StaticQualifiedUsingExpression.class);
   }
 

diff --git a/docs/bugpattern/DivZero.md b/docs/bugpattern/DivZero.md