Skip to content

fix rendering for both jekyll and github #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions review/developer/handling-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ If you can't answer that question, ask the reviewer for clarification.
And then, if you understand the comments but disagree with them, it's important
to think collaboratively, not combatively or defensively:

```txt {.bad}
``` {.bad}
Bad: "No, I'm not going to do that."
```

```txt {.good}
``` {.good}
Good: "I went with X because of [these pros/cons] with [these tradeoffs]
My understanding is that using Y would be worse because of [these reasons].
Are you suggesting that Y better serves the original tradeoffs, that we should
Expand Down
2 changes: 2 additions & 0 deletions review/developer/small-cls.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,15 @@ To take this a step further, you could combine these approaches and chart out an
implementation plan like this, where each cell is its own standalone CL.
Starting from the model (at the bottom) and working up to the client:

```
| Layer | Feature: Multiplication | Feature: Division |
| ------- | ------------------------- | ------------------------------- |
| Client | Add button | Add button |
| API | Add endpoint | Add endpoint |
| Service | Implement transformations | Share transformation logic with |
: : : multiplication :
| Model | Add proto definition | Add proto definition |
```

## Separate Out Refactorings {#refactoring}

Expand Down