Add acceptance criteria validation in functionality section to improve code review performance #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation talks that its hard to understand how some changes will impact a user just reading the code. However, just the UI changes are mentioned. Actually, the acceptance criteria and business necessity also cannot be validated just by reading the code. I wrote an article about it right here: https://www.linkedin.com/pulse/fac-review-strategy-johnatan-kayevo-obgof/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification can improve the performance in the code review process for the developer's team.
The documentation talks that its hard to understand how some changes will impact a user just reading the code. However, just the UI changes are mentioned. Actually, the acceptance criteria and business necessity also cannot be validated just by reading the code.
I wrote an article on Linkedin about it right here: Article about testing code before code review analysis
Testing before the coding review flow:
Testing after the coding review flow:
The results:
