-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ga_s2ls_intertidal #1197
base: main
Are you sure you want to change the base?
Add ga_s2ls_intertidal #1197
Conversation
'gee:visualizations': [ | ||
{ | ||
display_name: 'DEA Intertidal', | ||
lookat: {lon: 133.88, lat: -23.70, zoom: 5}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These coordinates are pointing to the center of Australia. Please correct them to match the preview script.
'australia', | ||
'ga', | ||
'dem', | ||
// 'landsat_sentinel2_derived' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commented lines can be removed.
local self_url = catalog_subdir_url + base_filename; | ||
|
||
{ | ||
stac_version: ee_const.stac_version, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you set 'gee:status': 'beta' for a new dataset?
I need to make some changes in checks to avoid having to do this in the future, but for now this would simplify the workflow a bit for us.
@@ -0,0 +1,135 @@ | |||
local id = 'projects/geoscience-aus-cat/assets/ga_s2ls_intertidal_cyear_3'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the thumbnali is very similar to the one for https://developers.google.com/earth-engine/datasets/catalog/projects_geoscience-aus-cat_assets_NIDEM
Does GA plan to mark NIDEM as deprecated by this dataset? If yes, we might want to hide NIDEM from the main list at https://developers.google.com/earth-engine/datasets/publisher/geoscience-aus-cat . If no, is it possible to use a slightly different thumbnail?
@@ -161,8 +161,8 @@ local self_url = catalog_subdir_url + base_filename; | |||
nbart_swir_1: {minimum: 0, maximum: 10000, 'gee:estimated_range': true}, | |||
nbart_swir_2: {minimum: 0, maximum: 10000, 'gee:estimated_range': true}, | |||
edev: {minimum: 0, maximum: 10000, 'gee:estimated_range': true}, | |||
sdev: {minimum: 0, maximum: 10000, 'gee:estimated_range': true}, | |||
bcdev: {minimum: 0, maximum: 10000, 'gee:estimated_range': true}, | |||
sdev: {minimum: 0, maximum: 1, 'gee:estimated_range': true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is about updating another dataset, so ideally it should be in a separate PR.
'dem', | ||
// 'landsat_sentinel2_derived' | ||
// 'intertidal', | ||
// 'elevation', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, 'elevation' is fine to keep. 'intertidal' is fine too.
No description provided.