Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ga_ls8cls9c_gm #1184

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update ga_ls8cls9c_gm #1184

wants to merge 6 commits into from

Conversation

ShiruiH
Copy link
Contributor

@ShiruiH ShiruiH commented Nov 4, 2024

No description provided.

@ShiruiH
Copy link
Contributor Author

ShiruiH commented Nov 4, 2024

Update files for projects_geoscience-aus-cat_assets_ga_ls8cls9c_gm_cyear_3

@@ -0,0 +1,4 @@
[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To apply this file to dataset descriptions (to create links between them and to display a warning on the old dataset's page), you should import it into both old and new .jsonnet files. Example: https://github.com/google/earthengine-catalog/blob/main/catalog/UMD/UMD_hansen_global_forest_change_2023_v1_11.jsonnet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Simon, I updated both the old and new .jsonnet files.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add "version_config.version_links" to the links section in both files? See https://github.com/google/earthengine-catalog/blob/main/catalog/UMD/UMD_hansen_global_forest_change_2023_v1_11.jsonnet#L45

This is the command that will create predecessor/successor links. The checks will also ask you to add "deprecated: true" to the old dataset, as it will now have a successor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version_config.version_links was added to both files. 'gee:status': 'deprecated' and [deprecated] were added to the old dataset file.

@@ -0,0 +1,27 @@
var geomedian_ls8ls9 = ee.ImageCollection('projects/geoscience-aus-cat/assets/ga_ls8cls9c_gm_cyear_3');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please make the collection publicly readable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format: 'png',
};

print(ui.Thumbnail({image: composite.visualize(visualization), params: imageParams}));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This thumbnail is partially masked out, so it won't look like a neat square. Could you either shift it to an area that's not fully masked out or use gray background like in https://github.com/google/earthengine-catalog/blob/main/examples/WM/WM_geoLab_geoBoundaries_600_ADM0_preview.js#L21 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the thumbnail area, now it should show a neat square.

@@ -0,0 +1,4 @@
[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add "version_config.version_links" to the links section in both files? See https://github.com/google/earthengine-catalog/blob/main/catalog/UMD/UMD_hansen_global_forest_change_2023_v1_11.jsonnet#L45

This is the command that will create predecessor/successor links. The checks will also ask you to add "deprecated: true" to the old dataset, as it will now have a successor.

copybara-service bot pushed a commit that referenced this pull request Nov 6, 2024
Superseded the previous L8-only GA dataset

PiperOrigin-RevId: 693792443
copybara-service bot pushed a commit that referenced this pull request Nov 7, 2024
Superseded the previous L8-only GA dataset

PiperOrigin-RevId: 693792443
copybara-service bot pushed a commit that referenced this pull request Nov 7, 2024
Superseded the previous L8-only GA dataset

PiperOrigin-RevId: 693792443
copybara-service bot pushed a commit that referenced this pull request Nov 7, 2024
Superseded the previous L8-only GA dataset

PiperOrigin-RevId: 694168285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants