-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ga_ls8cls9c_gm #1184
base: main
Are you sure you want to change the base?
Update ga_ls8cls9c_gm #1184
Conversation
Update files for projects_geoscience-aus-cat_assets_ga_ls8cls9c_gm_cyear_3 |
@@ -0,0 +1,4 @@ | |||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To apply this file to dataset descriptions (to create links between them and to display a warning on the old dataset's page), you should import it into both old and new .jsonnet files. Example: https://github.com/google/earthengine-catalog/blob/main/catalog/UMD/UMD_hansen_global_forest_change_2023_v1_11.jsonnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Simon, I updated both the old and new .jsonnet files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add "version_config.version_links" to the links section in both files? See https://github.com/google/earthengine-catalog/blob/main/catalog/UMD/UMD_hansen_global_forest_change_2023_v1_11.jsonnet#L45
This is the command that will create predecessor/successor links. The checks will also ask you to add "deprecated: true" to the old dataset, as it will now have a successor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version_config.version_links
was added to both files. 'gee:status': 'deprecated'
and [deprecated]
were added to the old dataset file.
@@ -0,0 +1,27 @@ | |||
var geomedian_ls8ls9 = ee.ImageCollection('projects/geoscience-aus-cat/assets/ga_ls8cls9c_gm_cyear_3'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please make the collection publicly readable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format: 'png', | ||
}; | ||
|
||
print(ui.Thumbnail({image: composite.visualize(visualization), params: imageParams})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This thumbnail is partially masked out, so it won't look like a neat square. Could you either shift it to an area that's not fully masked out or use gray background like in https://github.com/google/earthengine-catalog/blob/main/examples/WM/WM_geoLab_geoBoundaries_600_ADM0_preview.js#L21 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the thumbnail area, now it should show a neat square.
@@ -0,0 +1,4 @@ | |||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add "version_config.version_links" to the links section in both files? See https://github.com/google/earthengine-catalog/blob/main/catalog/UMD/UMD_hansen_global_forest_change_2023_v1_11.jsonnet#L45
This is the command that will create predecessor/successor links. The checks will also ask you to add "deprecated: true" to the old dataset, as it will now have a successor.
Superseded the previous L8-only GA dataset PiperOrigin-RevId: 693792443
Superseded the previous L8-only GA dataset PiperOrigin-RevId: 693792443
Superseded the previous L8-only GA dataset PiperOrigin-RevId: 693792443
Superseded the previous L8-only GA dataset PiperOrigin-RevId: 694168285
No description provided.