Make install-tools command work from any directory in the workspace. #2725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-kerscher
requested changes
Apr 30, 2025
xtask/src/main.rs
Outdated
| @@ -54,6 +54,11 @@ fn execute_task() -> Result<()> { | |||
| fn install_tools() -> Result<()> { | |||
| println!("Installing project tools..."); | |||
|
|
|||
| let path_to_mdbook_exerciser = | |||
| format!("{}mdbook-exerciser", env!("CARGO_WORKSPACE_DIR")); | |||
There was a problem hiding this comment.
I would like to wrap the workspace dir from the environment in a Path and join here with the directory name to get a proper path that can be easily converted to a string. That way you don't get into the trouble of formatting with the right dir separators.
|
regarding the failed |
michael-kerscher
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2708 by creating a CARGO_WORKSPACE_DIR env variable to act as an anchor path, allowing the installation of mdbook-exerciser and mdbook-course to succeed from any directory within the repository. Based on the approach mentioned here: rust-lang/cargo#3946 (comment)