-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'dprint fmt' results for .po files #2166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for pt-BR changes.
Oh, that's not good! I haven't noticed problems with the caching myself, but that is of course not a guarantee for anything 😄
We should fix this so that we get stable and consistent results. The formatting plugins for |
I suspect this particular issue is actually a
|
Huh, same version in CI
|
Dprint uses I can confirm that
which suggests that there is some different gettext-utils configuration here? I wondered if it is simply that the default for Perhaps this has something to do with the calculation of unicode line widths? Setting LC_ALL to various things ( Other ideas? |
See #2173. |
I cleared
$HOME/.cache/dprint
on my machine and re-randprint check
(which had previously succeeded), and it generated these changes.Somewhat aside, it's frustrating that
dprint
is very much a moving target, and moves at a different pace than our PRs. As a concrete example, this PR will also fail due to #2165. And, the check is required to merge, so until that's fixed we can't merge anything.