Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi: Day 1 Morning - Types and Values translation #2020

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

khoaxuantu
Copy link
Contributor

Here is the translation of Day 1 Morning: Type and Values translation.


It seems like there is no corresponding definition of hygienic macros in Vietnamese, so I think keeping its English word is fine.

Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks LGMT! Does this need any changes @daivinhtran

po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khoaxuantu can you try running the mdbook again?

po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
qu-ngx
qu-ngx previously requested changes May 7, 2024
Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Vinh that you'd better provide translation for the base case and recursive case.

@qu-ngx qu-ngx self-assigned this May 7, 2024
@khoaxuantu
Copy link
Contributor Author

I agree with Vinh that you'd better provide translation for the base case and recursive case.

Okay! I will change it soon.

Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good rn. Do you still have problems running mdbook for the first two lines of the docs?

Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khoaxuantu For now, please lemme try running mdbook on my machine locally.

@mgeisler
Copy link
Collaborator

Hi @khoaxuantu, can you rebase this PR and resolve the conflicts?

@qu-ngx, can we merge this afterwards?

@mgeisler mgeisler dismissed qu-ngx’s stale review August 21, 2024 07:42

If I read the comments correctly, the state was good three months ago

@mgeisler
Copy link
Collaborator

I looked at the conflict and it was tiny, so I resolved it. I also removed the changes to the msgid fields — we want you to either refresh the translation with msgmerge or modify the existing translation.

@mgeisler mgeisler enabled auto-merge (squash) August 21, 2024 07:43
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the discussion, I believe this is good to merge.

@mgeisler mgeisler merged commit ea12093 into google:main Aug 21, 2024
36 checks passed
@mgeisler
Copy link
Collaborator

This bumped Vietnamese up a lot in https://google.github.io/comprehensive-rust/translation-report.html 🎉 Before there were 480 translated strings, now there will be 547 based on running the report locally.

@khoaxuantu
Copy link
Contributor Author

@mgeisler I couldn't respond immediately when you mentioned me because of my on-going working hours. The PR was pending before due to a few conflicts in the Excersie: Fibonacci part, as I stated here.

Now, I see that it has been resolved in another PR, so it is good to merge then. Thank you for having resolved it for me 🙇

@mgeisler
Copy link
Collaborator

@mgeisler I couldn't respond immediately when you mentioned me because of my on-going working hours.

No worries at all, I understand that reviewing these PRs is hard and tedious work. They often end up getting stale because of small conflicts here and there, so that is why I tried to push it over the finishing line 😄

I just hope I don't make a mess out of it, since I cannot read anything in the PRs.

The PR was pending before due to a few conflicts in the Excersie: Fibonacci part, as I stated here.

Now, I see that it has been resolved in another PR, so it is good to merge then. Thank you for having resolved it for me 🙇

Thanks for confirming, I'm glad I could help!

@mgeisler
Copy link
Collaborator

By the way, see #1948 (comment) for a multi-step procedure to hand-merging out of date .po files. I basically treat them as two big maps of (msgid, msgstr) entries and put them together in a naive use-first way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants