Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Webassembly #1056

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

[WIP] Webassembly #1056

wants to merge 28 commits into from

Conversation

sakex
Copy link
Collaborator

@sakex sakex commented Aug 8, 2023

No description provided.

@sakex sakex marked this pull request as draft August 8, 2023 11:37

```

We want to edit the function `edit_bitmap`. `image_data` is a reference to the [Uint8ClampedArray](https://rustwasm.github.io/wasm-bindgen/api/js_sys/struct.Uint8ClampedArray.html) being rendered on your screen. `Uint8ClampedArray` is a flat array of unsigned int of `8` bits.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update dprint.json to include the new files under src/exercises/webassembly/ and src/webassembly/? That way we can ensure they're formatted in a consistent way!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I don't know how to do this, do you have an example?

src/webassembly.md Outdated Show resolved Hide resolved
src/webassembly.md Outdated Show resolved Hide resolved
@mgeisler
Copy link
Collaborator

mgeisler commented Aug 8, 2023

Hey @sakex, thanks a lot for putting this up! It's really cool to get a new section for the course 😄

I haven't yet checked it locally, but I like the exercises you've found.

@sakex
Copy link
Collaborator Author

sakex commented Aug 9, 2023

@mgeisler I pushed a commit with your fixes. I will do a pass next week to find what I'm missing and where the aspect ratio looks bad. Thanks for having a first look :)

src/SUMMARY.md Outdated Show resolved Hide resolved
@randomPoison
Copy link
Collaborator

I'll go through this and do a proper review soon (hopefully 🤞), but for now @sakex do you have any outstanding changes here that you're still planning on making? Seems like you've addressed all the feedback from @mgeisler's review. If not, does this still need to be a draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants