[Logging] Add structured log context to Triage #4787
Merged
+130
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanlacerda
approved these changes
May 12, 2025
Triage is executed as a cronjob, so I added the cron-related context (which logs the task name/ID). The entry points for the cronjobs is already instrumented setting the env vars with this information (#4781). |
vitorguidi
reviewed
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds structured logging to the triage job.
To enable this, the triage code was instrumented with the cron log context and with the testcase-based context, which wraps each triage execution for a given testcase. To avoid indenting the whole function, a new private method was created for triaging a single testcase.
Note: grouper will be instrumented in a next PR after #4781 is merged.
Test