Use a bash init script for starting instances on batch. #4786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some setup that is needed that cannot be done by the container.
vitorguidi
reviewed
May 7, 2025
| @@ -122,19 +126,19 @@ def create_uworker_main_batch_jobs(batch_tasks: List[BatchTask]): | |||
| return jobs | |||
|
|
|||
|
|
|||
| @functools.cache | |||
| def get_linux_linit_script() -> str: | |||
There was a problem hiding this comment.
This is an infrastructure definition, IMO it should live under the clusterfuzz-config repo. More specifically, under configs/batch.
If this lives here, whenever we want to change the script, we will have to open a public PR in a code repo to change an infrastructcure configuration, which is precise one of the problems @javanlacerda is trying to solve with his argocd stuff by moving kubernetes definitions away from here.
Wdyt?
There was a problem hiding this comment.
+1. would be good to move it there.
@jonathanmetzman is it easy to do this now? otherwise this could be a TODO for now.
There was a problem hiding this comment.
I think it isn't hard to move this. Will do
oliverchang
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some setup that is needed that cannot be done by the container.