MNT Removing the Fluentd setup and updating to default to GCP logging #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaliset
force-pushed
the
fluentd_removal
branch
2 times, most recently
from
52a90e7 to
2e4a1c0
Compare
vitaliset
force-pushed
the
fluentd_removal
branch
from
2e4a1c0 to
828c30f
Compare
oliverchang
reviewed
Feb 21, 2025
| This is disabled for local development and if we are running in a app engine | ||
| or kubernetes as these have their dedicated loggers, see | ||
| configure_appengine() and configure_k8s().""" | ||
| return bool(os.getenv('LOG_TO_GCP')) and not _is_local( | ||
| ) and not _is_running_on_app_engine() and not _is_running_on_k8s() | ||
| return (bool(os.getenv("LOG_TO_GCP", "True")) and |
There was a problem hiding this comment.
nit: use single quotes for strings.
| @@ -412,6 +389,8 @@ def cloud_label_filter(record): | |||
|
|
|||
| handler.addFilter(cloud_label_filter) | |||
| handler.setLevel(logging.INFO) | |||
| formatter = JsonFormatter() | |||
| handler.setFormatter(formatter) | |||
|
|
|||
| logging.getLogger().addHandler(handler) | |||
There was a problem hiding this comment.
will we still have file logs in the bots directory this way? This can be a followup TODO if not.
File logs have been very useful in the past for debugging, when cloud logs somehow don't exist (e.g. network or some other issue).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.