-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable deploying chrome-tests-syncer independently #4647
Conversation
Please describe the testing strategy adopted, and post evidence that the change does what it is meant to do (for instance, the manual deployment for isolated test syncer that we performed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Motivation
Decouple the chrome-tests-syncer code releases from the rest of clusterfuzz, in order to enable it to be deployed independently of the clusterfuzz instances by the chrome fuzzing team .
Changes
Tests
Deployed a chrome-tests-syncer release using this PR and produced the dedicated artifact (https://screenshot.googleplex.com/8W88DmYwFKPkSfZ.png).
Built an updated chrome-tests-syncer image that pulls from this artifact (https://screenshot.googleplex.com/8HqEvV7bnBggBPj.png).
Created the chrome-tests-syncer cronjob (along with PR in clusterfuzz-config: 2428107) pulling from this updated image, applied it to the GKE and it ran successfully:
Mocked a deployment with --release=prod (by printing the command instead of actually uploading to gcs):
Bug: b/389048599