Update how profiler enabled flag is checked #4621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorguidi
reviewed
Jan 16, 2025
vitorguidi
reviewed
Jan 17, 2025
|
PR blocked until dependency issues are resolved. google-cloud-profiler package is built locally and depends on the glibc version. Currently, local dev environment differs from clusterfuzz bots env, making the bots crash when the profiler tries to import the .so files. (credit to @vitorguidi for finding this bug). Bug: b/388257931 |
|
I think we can still land this even though the main part of the work is blocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to enable Cloud Profiler for clusterfuzz by using the flag in the project config yaml. This change is supported by a PR in clusterfuzz configs repo.
In addition, remove profiler calls from fuzzer engines, since having it only in the bot startup is enough granularity.