Remove untrusted_runner from misc files. #4551
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used anymore.
It's not used anymore.
vitorguidi
reviewed
Dec 26, 2024
| @@ -705,12 +705,6 @@ def is_posix(): | |||
| return os.name == 'posix' | |||
|
|
|||
|
|
|||
| def is_trusted_host(ensure_connected=True): | |||
There was a problem hiding this comment.
There is also a test file for this, environment_test.py. It should also be changed, right?
There was a problem hiding this comment.
The same goes for UntrustedRunnerIntegrationTest
There was a problem hiding this comment.
The problem with these PRs is that I think the untrusted runner tests provide coverage for non-untrusted code that is otherwise not covered. I should try to convert these to normal tests rather than get rid of them.
jonathanmetzman
force-pushed
the
oss-fuzz
branch
5 times, most recently
from
f233e5f to
43295d1
Compare
jonathanmetzman
force-pushed
the
oss-fuzz
branch
from
0c16f8c to
e8834a1
Compare
|
This pull request has not had any activity for 60 days and will be automatically closed in two weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not used anymore.
Bug: b/381528482