-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Temporary 3.7 deployment #4163
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit af69605.
…e 311 bump pr that was reverted
vitorguidi
changed the title
[DO NOT MERGE] Temorary 3.7 deployment
[DO NOT MERGE] Temporary 3.7 deployment
Aug 14, 2024
This reverts commit 015f6a3.
#4165) OSS-Fuzz has project-specific queues, which breaks this.
This is required for OSS-Fuzz after the uworker refactor. This fixes the following exception: ``` Error occurred while working on task. Traceback (most recent call last): File "/mnt/scratch0/bots/oss-fuzz-linux-zone1-host-bsw9-13/clusterfuzz/src/python/bot/startup/run_bot.py", line 146, in task_loop commands.process_command(task) File "/mnt/scratch0/bots/oss-fuzz-linux-zone1-host-bsw9-13/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/commands.py", line 249, in process_command task.high_end, task.is_command_override) File "/mnt/scratch0/bots/oss-fuzz-linux-zone1-host-bsw9-13/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/commands.py", line 159, in wrapper return func(task_name, task_argument, job_name, *args, **kwargs) File "/mnt/scratch0/bots/oss-fuzz-linux-zone1-host-bsw9-13/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/commands.py", line 433, in process_command_impl preprocess) File "/mnt/scratch0/bots/oss-fuzz-linux-zone1-host-bsw9-13/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/commands.py", line 218, in run_command result = task.execute(task_argument, job_name, uworker_env) File "/mnt/scratch0/bots/oss-fuzz-linux-zone1-host-bsw9-13/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/task_types.py", line 105, in execute self.execute_locally(task_argument, job_type, uworker_env) File "/mnt/scratch0/bots/oss-fuzz-linux-zone1-host-bsw9-13/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/task_types.py", line 63, in execute_locally uworker_output = utasks.uworker_main_no_io(self.module, uworker_input) File "/mnt/scratch0/bots/oss-fuzz-linux-zone1-host-bsw9-13/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/utasks/__init__.py", line 211, in uworker_main_no_io uworker_output = utask_module.utask_main(uworker_input) File "/mnt/scratch0/bots/oss-fuzz-linux-zone1-host-bsw9-13/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/utasks/fuzz_task.py", line 1919, in utask_main return session.run() File "/mnt/scratch0/bots/oss-fuzz-linux-zone1-host-bsw9-13/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/utasks/fuzz_task.py", line 1731, in run self.fuzz_task_output.fuzz_targets.extend(build_setup_result.fuzz_targets) TypeError: Value must be iterable ```
Fix problem in oss-fuzz where manage_vms doesn't complete, causing old VMs/containers to hang around. Do this by increasing the deadline to 24 hours for manage_vms to compelte. Also, temporarily change the order of manage_vms so that the previously unresized groups will be resized first. This should hopefully get rid of weird errors we are seeing.
…g_task_input' (#4168) This was caused by the roll forward of oss-fuzz.
It's simpler to use timestamps with protos, and we've been doing this already in chrome and internal google. Fixes: https://pantheon.corp.google.com/errors/detail/CM3Hppa8wfSgCQ;time=PT6H;locations=global?e=-13802955&mods=logs_tg_prod&project=clusterfuzz-external ``` AttributeError: 'datetime.date' object has no attribute 'utctimetuple' at .FromDatetime ( /mnt/scratch0/bots/oss-fuzz-linux-zone5-host-9xqb-0/clusterfuzz/src/third_party/google/protobuf/internal/well_known_types.py:270 ) at ._extract_coverage_information ( /mnt/scratch0/bots/oss-fuzz-linux-zone5-host-9xqb-0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/utasks/corpus_pruning_task.py:960 ) at .utask_main ( /mnt/scratch0/bots/oss-fuzz-linux-zone5-host-9xqb-0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/utasks/corpus_pruning_task.py:1024 ) ```
jonathanmetzman
force-pushed
the
temp/37-deploy
branch
from
August 19, 2024 18:41
0506ab8
to
1a3ca82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need the ability to maneuver code between 3.7 and 3.11 in order to rollback potential failure scenarios. This branch serves this purpose.
How to deploy:
outside of pipenv
PYTHON=python3.7 ./local/install_deps.sh
python3.7 -m pipenv shell
within pipenv
regular butler command
Gotchas
Windows used to delete all of clusterfuzz files during update task, and this was resolved in #4025. This was added as the second commit in this PR
This, when deployed, will switch the k8s cronjobs to fetch the production code release and run python 3.7