-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bazel): add MODULE.bazel files for bzlmod #354
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied go mod tidy
on this, that's the reason it's updated.
/gcbrun |
Any update ? |
Could we please get this merged in? The weirdness of how this bazel project is defined is causing a ton of pain downstream. See: cncf/xds#97 I would also like: #379 added on as well so we can finally solve this issue. |
@aaomidi we've actually had a lot of trouble getting the bazel modules to work correctly with all of the stacks (c++, java, go) which is why we have held off on this change. I'll be looking into this more soon though given the pain point |
There is an option here which is just exposing a Cheers! |
Signed-off-by: Matthieu MOREL <[email protected]>
@TristonianJones , |
/gcbrun |
@mmorel-35 I'm planning to spend time this quarter to update the Bazel deps. Thank you for your patience. |
Closes #348