Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bazel): add MODULE.bazel files for bzlmod #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmorel-35
Copy link

@mmorel-35 mmorel-35 commented May 4, 2024

Closes #348

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied go mod tidy on this, that's the reason it's updated.

@TristonianJones
Copy link
Collaborator

/gcbrun

@mmorel-35
Copy link
Author

Any update ?

@aaomidi
Copy link
Contributor

aaomidi commented Aug 17, 2024

Could we please get this merged in? The weirdness of how this bazel project is defined is causing a ton of pain downstream.

See: cncf/xds#97

I would also like: #379 added on as well so we can finally solve this issue.

@TristonianJones
Copy link
Collaborator

@aaomidi we've actually had a lot of trouble getting the bazel modules to work correctly with all of the stacks (c++, java, go) which is why we have held off on this change. I'll be looking into this more soon though given the pain point

@aaomidi
Copy link
Contributor

aaomidi commented Aug 19, 2024

There is an option here which is just exposing a proto_library, and letting downstream users write their own language specific compiled protos against this if its a pain point as a start (?)

Cheers!

@mmorel-35
Copy link
Author

mmorel-35 commented Sep 1, 2024

@TristonianJones ,
This branch has been rebased.
Can you review when you find the time ?

@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones
Copy link
Collaborator

@mmorel-35 I'm planning to spend time this quarter to update the Bazel deps. Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bzlmod for v0.14.0
3 participants