Report compile issue of expr string only if strict flag is set (#49)

* Report issues if strict flag is set * Update compile error test
google · Sep 10, 2021 · 87f0797 · 87f0797
1 parent 2ad8ac2
commit 87f0797
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/policy/compiler/compiler.go b/policy/compiler/compiler.go
@@ -917,9 +917,9 @@ func (tc *templateCompiler) compileExprString(id int64,
 	ast, iss := env.ParseSource(relSrc)
 	if iss.Err() == nil {
 		// If the expression parses, then it's probably CEL.
-		// Report type-check issues if they are encountered.
+		// Report type-check issues if they are encountered and strict flag is true.
 		ast, iss = env.Check(ast)
-		if iss.Err() != nil {
+		if iss.Err() != nil && strict {
 			tc.reportIssues(iss)
 			return nil
 		}

diff --git a/test/testdata/validator_with_custom_function/template.invalid_function.compile.err b/test/testdata/validator_with_custom_function/template.invalid_function.compile.err
@@ -1,6 +1,3 @@
 ERROR: ../../test/testdata/validator_with_custom_function/template.invalid_function.yaml:30:23: undeclared reference to 'invalidFunc' (in container '')
  |   - match: invalidFunc(rule.port) < 0
- | ......................^
-ERROR: ../../test/testdata/validator_with_custom_function/template.invalid_function.yaml:31:15: undeclared reference to 'invalidFunc' (in container '')
- |     message: "invalidFunc"
- | ..............^
+ | ......................^