Thread-safety fix for unprotected mutation of decorator set. (#621)

Signed-off-by: Tim Ramlot <[email protected]> Signed-off-by: Tim Ramlot <[email protected]> Co-authored-by: Tim Ramlot <[email protected]>
google · Jan 5, 2023 · 1ad0c88 · 1ad0c88
1 parent 6efb4a8
commit 1ad0c88
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/cel/program.go b/cel/program.go
@@ -201,7 +201,10 @@ func newProgram(e *Env, ast *Ast, opts []ProgramOption) (Program, error) {
 		factory := func(state interpreter.EvalState, costTracker *interpreter.CostTracker) (Program, error) {
 			costTracker.Estimator = p.callCostEstimator
 			costTracker.Limit = p.costLimit
-			decs := decorators
+			// Limit capacity to guarantee a reallocation when calling 'append(decs, ...)' below. This
+			// prevents the underlying memory from being shared between factory function calls causing
+			// undesired mutations.
+			decs := decorators[:len(decorators):len(decorators)]
 			var observers []interpreter.EvalObserver
 
 			if p.evalOpts&(OptExhaustiveEval|OptTrackState) != 0 {