Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for mlflow in caliban shell #83

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ajslone
Copy link
Collaborator

@ajslone ajslone commented Aug 12, 2020

This PR adds support for mlflow reporting via cloud_sql_proxy in caliban shell.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #83 into master will increase coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   51.83%   51.90%   +0.07%     
==========================================
  Files          31       31              
  Lines        3158     3169      +11     
==========================================
+ Hits         1637     1645       +8     
- Misses       1521     1524       +3     
Impacted Files Coverage Δ
caliban/platform/run.py 27.96% <0.00%> (-0.49%) ⬇️
caliban/docker/build.py 33.78% <25.00%> (-0.01%) ⬇️
caliban/platform/shell.py 35.48% <50.00%> (+1.00%) ⬆️
caliban/util/metrics.py 100.00% <100.00%> (ø)
caliban/platform/gke/util.py 71.37% <0.00%> (+0.38%) ⬆️
caliban/platform/cloud/types.py 90.50% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9062a7b...1de728e. Read the comment docs.

@ajslone ajslone requested a review from sritchie August 12, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant