Skip to content

Commit

Permalink
Ghidra: Skip functions in non-loaded address spaces
Browse files Browse the repository at this point in the history
For instance, functions that are created for readability by scripts such as
the [Linux syscall resolver](https://github.com/NationalSecurityAgency/ghidra/blob/master/Ghidra/Features/Base/ghidra_scripts/ResolveX86orX64LinuxSyscallsScript.java)
have usually the type `AddressSpace::TYPE_OTHER` and their own namespace
(`syscall` in this case).

For those functions, the address offset will not be accurate and exporting
those functions makes the resulting .BinExport proto unsuitable for BinDiff
("Call graph nodes not sorted").

Drive-by changes:
- Remove `final` in local variables (per Google style guide)
- Replace the use of `java.util.Vector` which performs synchronization. Use
  `java.util.ArrayList` instead.

PiperOrigin-RevId: 373755052
Change-Id: Id38c7cfc95ff9ee7b621ccb432d3fdcac00b4ed5
  • Loading branch information
cblichmann authored and copybara-github committed May 14, 2021
1 parent 6a21a82 commit 48b0185
Showing 1 changed file with 106 additions and 90 deletions.
Loading

0 comments on commit 48b0185

Please sign in to comment.