Add Overlay and Navigation tests for the Interaction design #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes crashes where removeLast() can not be found on emulator 32. Fixes: #1712
timothyfroehlich
force-pushed
the
wb/froeht/add-overlay-tests
branch
from
e75f3d2
to
5c2df23
Compare
timothyfroehlich
force-pushed
the
wb/froeht/add-overlay-tests
branch
from
5c2df23
to
944d48c
Compare
|
Snapshot diff report vs base branch: yiqunw/overlay_dismiss |
timothyfroehlich
force-pushed
the
wb/froeht/add-overlay-tests
branch
from
944d48c
to
1795056
Compare
timothyfroehlich
changed the title
timothyfroehlich
force-pushed
the
wb/froeht/gradle-8-10-2
branch
from
dc873fb
to
3817d3b
Compare
timothyfroehlich
changed the base branch from
wb/froeht/gradle-8-10-2
to
yiqunw/overlay_dismiss
timothyfroehlich
force-pushed
the
wb/froeht/add-overlay-tests
branch
from
1795056
to
d1f29f2
Compare
|
I am wondering how you made the "PR Chain"? Does github show that based on the description "Based on PR #1715"? |
yiqunw700
approved these changes
Oct 10, 2024
|
I've been using something called "git machete", it's got a bit of a
learning curve, but it does have a plugin for Android Studio and it's been
mostly helpful :)
…On Thu, Oct 10, 2024 at 1:29 PM yiqunw700 ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#1711 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMM2SUKILCP7LLRDXR4O2LZ23BQ3AVCNFSM6AAAAABPMPZTWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRGEYTKMBZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Tim Froehlich
AAOS Customization Tools <https://moma.corp.google.com/team/1556788105958>
Located in Austin TX, GMT-5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #1715
Full chain of PRs as of 2024-10-10
wb/froeht/add-overlay-tests➔yiqunw/overlay_dismissyiqunw/overlay_dismiss➔main