Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moe Sync #681

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Moe Sync #681

merged 1 commit into from
Nov 20, 2018

Conversation

ronshapiro
Copy link
Contributor

This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.

Commits:

Fix incremental annotation processing of AutoValueProcessor, shade net.ltgt.gradle.incap

Related to #615
Closes #678

RELNOTES=Fix incremental annotation processing of @AutoValue

fd19a75

…t.ltgt.gradle.incap

Related to #615
Closes #678

RELNOTES=Fix incremental annotation processing of `@AutoValue`

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=221799723
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@ronshapiro ronshapiro merged commit 044ccda into master Nov 20, 2018
@ronshapiro ronshapiro deleted the sync-master-2018/11/19 branch November 20, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants