Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor usages of Json Parser for thread safety #2749

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

ndegwamartin
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2748

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@ndegwamartin ndegwamartin marked this pull request as ready for review December 4, 2024 12:15
@ndegwamartin ndegwamartin requested a review from a team as a code owner December 4, 2024 12:15
@ndegwamartin ndegwamartin requested a review from MJ1998 December 4, 2024 12:15
@aditya-07 aditya-07 enabled auto-merge (squash) December 10, 2024 17:51
Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aditya-07 aditya-07 merged commit 17029eb into google:master Dec 10, 2024
8 checks passed
@jingtang10 jingtang10 deleted the parser-thread-safety branch December 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread safety for FHIR Context Json Parser usage across the FHIR SDK
2 participants