Default m3 style to survey button. #2225

santosh-pingle · 2023-10-04T06:14:35Z

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes

Description
Apply default m3 button style to survey button, and remove the existing applied padding.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

I have read and acknowledged the Code of conduct.
I have read the Contributing page.
I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

santosh-pingle · 2023-10-04T06:15:06Z

demo/src/main/res/layout/patient_details_header.xml

…oogle#2241)

* Update material3 theme. * Support m3 night mode. * Address review comments. * Address review comments. * Change the color order. --------- Co-authored-by: Santosh Pingle <[email protected]>

…e#2235) (google#2236)

* Allow custom package server in Knowledge Manager * Fix downloader test * Fix workflow library * Update knowledge/src/main/java/com/google/android/fhir/knowledge/files/NpmFileManager.kt Co-authored-by: aditya-07 <[email protected]> * Fix build * Add try catch for package download --------- Co-authored-by: aditya-07 <[email protected]>

…ogle#2245) * Migrates engine to HAPI 6.8 while forcing Workflow to stay on 6.0 * comment

* Updates dependencies * Updates test cases * Removes moxy and antlr from dependencies. * Migrates the workflow to the new API * Migrates workflow testing to the new API * Fixes workflow benchmark module * Fixes workflow benchmark module * Adds contents.txt file to all test repos so it can be loaded on androidTest * Normalizes path before trying to open files * Uses contents.txt when running tests on Android * Spotless * Updating Json and XML comparisons to pass when elements are just out of order. * Ignores testANCDT17 for now

* Use launchContext for initialExpression * Test ResourceMapper * Fix test * Fix launchContexts for demo app when editing patient * spotlessApply * WIP * Revert "WIP" This reverts commit d2d53a2. * spotlessApply * Fix test * Refactor validateLaunchContextExtension * Remove QuestionnaireLaunchContextSet enum class * Rename vars and functions * Add code comment for MoreResourceTypes.kt * Unit testing * Fix post-merge-conflict * spotlessApply * Address review * spotlessApply * Revert un-intended changes * Fix failing checks * Remove check of must contain 2 sub-extensions * Update Kdoc * Revert * validate launch context when using populate public API

1. clarify the need to send a full reference "type/id" instead of just the ID 2. match the evaluator's name

* Use launchContext for initialExpression * Test ResourceMapper * Fix test * Fix launchContexts for demo app when editing patient * spotlessApply * WIP * Revert "WIP" This reverts commit d2d53a2. * spotlessApply * Fix test * Refactor validateLaunchContextExtension * Remove QuestionnaireLaunchContextSet enum class * Rename vars and functions * Add code comment for MoreResourceTypes.kt * Unit testing * Fix post-merge-conflict * spotlessApply * Address review * spotlessApply * Revert un-intended changes * Fix failing checks * Remove check of must contain 2 sub-extensions * Update Kdoc * Revert * validate launch context when using populate public API * Address Jing's Review - google#2025 (comment) - google#2025 (comment)

Bumps [com.squareup:kotlinpoet](https://github.com/square/kotlinpoet) from 1.12.0 to 1.14.2. - [Release notes](https://github.com/square/kotlinpoet/releases) - [Changelog](https://github.com/square/kotlinpoet/blob/main/docs/changelog.md) - [Commits](square/kotlinpoet@1.12.0...1.14.2) --- updated-dependencies: - dependency-name: com.squareup:kotlinpoet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jing Tang <[email protected]>

Bumps androidx.build.gradle.gcpbuildcache from 1.0.0-beta01 to 1.0.0-beta05. --- updated-dependencies: - dependency-name: androidx.build.gradle.gcpbuildcache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Omar Ismail <[email protected]>

…e#2253) Bumps [com.spotify.ruler:ruler-gradle-plugin](https://github.com/spotify/ruler) from 1.2.1 to 1.4.0. - [Release notes](https://github.com/spotify/ruler/releases) - [Changelog](https://github.com/spotify/ruler/blob/main/changelog.md) - [Commits](spotify/ruler@v1.2.1...v1.4.0) --- updated-dependencies: - dependency-name: com.spotify.ruler:ruler-gradle-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

….0 (google#2252) Bumps [com.diffplug.spotless:spotless-plugin-gradle](https://github.com/diffplug/spotless) from 6.21.0 to 6.22.0. - [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md) - [Commits](diffplug/spotless@gradle/6.21.0...gradle/6.22.0) --- updated-dependencies: - dependency-name: com.diffplug.spotless:spotless-plugin-gradle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jing Tang <[email protected]>

* Update dependencies in engine colab * update datacapture

Bumps [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) from 0.7.0 to 0.12.0. - [Release notes](https://github.com/styfle/cancel-workflow-action/releases) - [Commits](styfle/cancel-workflow-action@0.7.0...0.12.0) --- updated-dependencies: - dependency-name: styfle/cancel-workflow-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v2...v3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…server (google#2272) * Update the version of resource after updates are downloaded from the server * Review changes: Added tests and refactored code * Review comments updates

Santosh Pingle and others added 6 commits September 27, 2023 12:45

Update material3 theme.

85cc80c

Support m3 night mode.

52dd960

Merge branch 'master' into sp/issue-2188-m3-theme

d7173ce

Address review comments.

1f807ad

Address review comments.

aa7081d

Apply m3 default style to survey button.

815546e

santosh-pingle marked this pull request as ready for review October 4, 2023 06:16

santosh-pingle requested a review from a team as a code owner October 4, 2023 06:16

santosh-pingle requested a review from jingtang10 October 4, 2023 06:16

jingtang10 requested changes Oct 4, 2023

View reviewed changes

demo/src/main/res/layout/patient_details_header.xml Outdated Show resolved Hide resolved

Santosh Pingle and others added 2 commits October 9, 2023 12:37

Use default typography.

c408472

Merge branch 'master' into sp/issue-2188-survey-button

3356bcf

santosh-pingle requested a review from jingtang10 October 9, 2023 07:21

vorburger and others added 16 commits October 18, 2023 16:57

Fix broken dependabot.yaml syntax (fixes google#2195) (google#2234)

d474afa

Moves commons to Hapi 6.8, removes caffeine and forces guava-android (g…

1094749

…oogle#2241)

Bump up common library version to 0.1.0-alpha05 (google#2243)

54fa29f

Update material3 theme in demo app. (google#2211)

dbe25e0

* Update material3 theme. * Support m3 night mode. * Address review comments. * Address review comments. * Change the color order. --------- Co-authored-by: Santosh Pingle <[email protected]>

Fix broken dependabot.yaml syntax again (re. google#2195) (google#2242)

b8e9d1e

SdkSuppress FhirSyncWorkerBenchmark oneTimeSync_50patients (re. googl…

b14bb07

…e#2235) (google#2236)

Bump up the version of knowledge manager (google#2258)

f77d3a3

Migrates engine to HAPI 6.8 while forcing Workflow to stay on 6.0 (go…

7a87ccc

…ogle#2245) * Migrates engine to HAPI 6.8 while forcing Workflow to stay on 6.0 * comment

Renames patientId param to subject to: (google#2263)

706f7e0

1. clarify the need to send a full reference "type/id" instead of just the ID 2. match the evaluator's name

dependabot bot and others added 7 commits October 18, 2023 17:04

Update dependencies in engine colab (google#2268)

543d0ef

* Update dependencies in engine colab * update datacapture

Update the version of resource after updates are downloaded from the …

084e2e1

…server (google#2272) * Update the version of resource after updates are downloaded from the server * Review changes: Added tests and refactored code * Review comments updates

Merge branch 'master' into sp/issue-2188-survey-button

df54903

jingtang10 approved these changes Oct 18, 2023

View reviewed changes

jingtang10 enabled auto-merge (squash) October 18, 2023 12:48

jingtang10 and others added 2 commits October 18, 2023 13:48

Merge branch 'master' into sp/issue-2188-survey-button

59b9e98

Merge branch 'master' into sp/issue-2188-survey-button

53828ab

jingtang10 merged commit cf838c6 into google:master Oct 19, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Default m3 style to survey button. #2225

Default m3 style to survey button. #2225

santosh-pingle commented Oct 4, 2023

santosh-pingle commented Oct 4, 2023

Default m3 style to survey button. #2225

Default m3 style to survey button. #2225

Conversation

santosh-pingle commented Oct 4, 2023

santosh-pingle commented Oct 4, 2023