Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dependabot.yaml (fixes #2195) #2196

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

vorburger
Copy link
Member

Fixes #2195

Description
This (should) enable https://github.com/dependabot, see https://docs.github.com/en/code-security/dependabot.

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Yes, always! 😺 I am aware of other such tools, but this is the best one, because it's from GitHub themselves, and thus most natively integrated. It also work great on many other open source projects where I have enabled it! 😃

Type
Choose one: Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Security

Screenshots (if applicable)
The expected result would be to start seeing automagical Pull Requests such as these (from another repo) on this repo.

@jingtang10
Copy link
Collaborator

@vorburger do we know if this works before merging the PR?

We have a centralised place to keep the dependency info: https://github.com/google/android-fhir/blob/master/buildSrc/src/main/kotlin/Dependencies.kt in the buildSrc folder. Is dependabot able to handle this?

@vorburger
Copy link
Member Author

@vorburger do we know if this works before merging the PR?

No, not easily, unfortunately. My recommendation is to just merge this as-is; we could always git revert later, if it's causing problems.

We have a centralised place to keep the dependency info: https://github.com/google/android-fhir/blob/master/buildSrc/src/main/kotlin/Dependencies.kt in the buildSrc folder. Is dependabot able to handle this?

Yes, I expect it will; note how, since #2208 for #2194, https://github.com/google/android-fhir/network/dependencies now shows this project's dependencies; my expectation is that when this PR gets merged, Dependabot will start proposing upgrades.

In order to easily see which upgrades proposed by Dependabot "work" , perhaps you would like to merge #2203 to fix #2197 before this?

@vorburger
Copy link
Member Author

Yes, I expect it will; note how ...

Actually... I see what you mean; I'm not sure if Dependabot is smart enough to propose a correct PR, for this project as-is. We may have to do some manual work. Let's try and see? If it doesn't work, perhaps we could rework Dependencies.kt?

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy for you to merge this but have you seen this: https://medium.com/@vladyslav.hontar/dependabot-in-action-d9b56b2be86c?

i commented in the issue too

@omarismail94 omarismail94 enabled auto-merge (squash) October 6, 2023 13:26
@omarismail94 omarismail94 merged commit a71109b into master Oct 6, 2023
@omarismail94 omarismail94 deleted the vorburger-dependabot branch October 6, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Set up Dependabot
3 participants