-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #2193
Spelling #2193
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
workflow-testing/src/main/java/com/google/android/fhir/workflow/testing/CqlBuilder.kt
Show resolved
Hide resolved
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Josh!
How can we make this part of our continuous build/testing?
@jingtang10: a commit close to jsoref@0029254#diff-aa48ce5bca2bfbf528400261b9c5a206f60410e880f71a80499efbe87ea236b2 could be added to the repository, I'd be happy to make such a PR (I tend to make a couple of adjustments -- especially setting up a feature for use in forks to ease configuration burden for contributors, and I need to incorporate a way to improve the handling of dependabot triggered PRs). But I like to talk to project owners to give them a sense of how things will work -- there are a bunch of tunables and it helps for people to understand what will happen before it's deployed. I'm available on Zulip if that's helpful. The main choices are:
|
Thanks - please feel free to send a pr. We can talk about the specifics in the pr. |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
Fixes misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/google-android-fhir/actions/runs/6288135984/attempts/1#summary-17073322067
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/google-android-fhir/actions/runs/6288136028/attempts/1#summary-17073322270
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Ignoring typos is always a possibility...
Type
Choose one: Trivial Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.