Replace vscaleexpminusmax yaml with header #7409
Open
+190
−1,543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include table header and remove yaml file
RahulSundarMCW
force-pushed
the
vscaleexpminusmax
branch
from
eda8b81
to
ab42c5a
Compare
RahulSundarMCW
force-pushed
the
vscaleexpminusmax
branch
2 times, most recently
from
cbdc5f8
to
2543af9
Compare
|
Address the review comments and pushed the commit. |
RahulSundarMCW
force-pushed
the
vscaleexpminusmax
branch
from
2543af9
to
2d6ecc5
Compare
RahulSundarMCW
commented
Nov 5, 2024
| XNN_UKERNEL_WITH_PARAMS(xnn_arch_x86_avx512f, xnn_f32_vscaleexpminusmax_ukernel__avx512f_p5_scalef_u160, 160, float, struct xnn_f32_default_params, ((xnn_f32_vscaleexpminusmax_ukernel_fn) NULL)) | ||
| XNN_UKERNEL_WITH_PARAMS(xnn_arch_x86_avx512f, xnn_f32_vscaleexpminusmax_ukernel__avx512f_p5_scalef_u176, 176, float, struct xnn_f32_default_params, ((xnn_f32_vscaleexpminusmax_ukernel_fn) NULL)) | ||
| XNN_UKERNEL_WITH_PARAMS(xnn_arch_x86_avx512f, xnn_f32_vscaleexpminusmax_ukernel__avx512f_p5_scalef_u192, 192, float, struct xnn_f32_default_params, ((xnn_f32_vscaleexpminusmax_ukernel_fn) NULL)) | ||
| #if XNN_ENABLE_AVX512F_U32 && (XNN_ARCH_X86 || XNN_ARCH_X86_64) |
There was a problem hiding this comment.
With XNN_ENABLE_AVX512F enabled, we encountered illegal instruction errors in these tests. We replaced it with XNN_ENABLE_AVX512F_U32. Can you look into this.
RahulSundarMCW
force-pushed
the
vscaleexpminusmax
branch
from
2d6ecc5
to
773892e
Compare
dsharletg
reviewed
Nov 6, 2024
RahulSundarMCW
force-pushed
the
vscaleexpminusmax
branch
2 times, most recently
from
81b010b
to
9942f67
Compare
RahulSundarMCW
force-pushed
the
vscaleexpminusmax
branch
from
9942f67
to
cf44276
Compare
RahulSundarMCW
force-pushed
the
vscaleexpminusmax
branch
from
c520980
to
aaf41aa
Compare
dsharlet
reviewed
Nov 12, 2024
| #endif | ||
|
|
||
| #if XNN_ARCH_X86 || XNN_ARCH_X86_64 | ||
| XNN_UKERNEL_WITH_PARAMS(xnn_arch_x86_avx2, xnn_f32_vscaleexpminusmax_ukernel__avx2_p5_u8, 8, float, struct xnn_f32_default_params, xnn_f32_vscaleexpminusmax_ukernel_fn) |
There was a problem hiding this comment.
I don't understand the last parameter of these, xnn_f32_vscaleexpminusmax_ukernel_fn? Why is this here?
RahulSundarMCW
force-pushed
the
vscaleexpminusmax
branch
from
6b3445a
to
0c16450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.