Uses CtapResult instead of explicit Result #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated with
```
find . -type f -name "*.rs" -exec sed -i 's/Result<\([^,]*\), Ctap2StatusCode>/CtapResult<\1>/g' {} \;
cd libraries/opensk
find . -type f -name "*.rs" -exec grep -q 'CtapResult' {} \; -exec sed -i '15 i\
use crate::ctap::status_code::CtapResult;
' {} +
```
Then we fix the last few compiler errors and run `cargo fmt`.
Next step is to move away from custom error types in the API to only use
CtapResult everywhere.
kaczmarczyck
force-pushed
the
ctap-result-refactoring
branch
from
0f2f823
to
e581101
Compare
ia0
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with
Then we fix the last few compiler errors and run
cargo fmt.Next step is to move away from custom error types in the API to only use CtapResult everywhere.