Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBOR API changes #639

Merged
merged 5 commits into from
Aug 11, 2023
Merged

CBOR API changes #639

merged 5 commits into from
Aug 11, 2023

Conversation

kaczmarczyck
Copy link
Collaborator

This is a series of PRs that change and close down the public API of our CBOR crate. The last of the 3 commits fixes #420.

All commits can be reviewed individually, and make sense on their own. I can split the PR in 3, but wanted to send out the overall solution first for an overview.

The downside is a slight (+1 kB) increase in binary size. Review is not urgent.

@kaczmarczyck kaczmarczyck requested a review from ia0 July 25, 2023 08:51
ia0
ia0 previously approved these changes Aug 8, 2023
@coveralls
Copy link

Coverage Status

coverage: 96.349% (+0.009%) from 96.34% when pulling 4fbc8f7 on kaczmarczyck:cbor-api into 87f0711 on google:develop.

@kaczmarczyck kaczmarczyck merged commit 8a53986 into google:develop Aug 11, 2023
24 checks passed
@kaczmarczyck kaczmarczyck deleted the cbor-api branch August 11, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants