Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Test pull-request for issue #169. #170

Closed
wants to merge 3 commits into from

Conversation

gendx
Copy link
Collaborator

@gendx gendx commented Sep 29, 2020

This is a test for the behavior in #169. This pull request can be removed and #169 marked as fixed once the GitHub checks fail here.

  • Tests pass
  • Appropriate changes to README are included in PR

@google-cla google-cla bot added the cla: yes label Sep 29, 2020
@jmichelp jmichelp changed the base branch from master to develop January 6, 2021 15:01
@kaczmarczyck
Copy link
Collaborator

@gendx Is this still uesful to be kept open as a canary?

@gendx
Copy link
Collaborator Author

gendx commented Sep 13, 2021

@gendx Is this still uesful to be kept open as a canary?

Just rebased this pull request to see if the Clippy workflow now fails.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.891% when pulling 951a310 on gendx:issue-169 into c1f2551 on google:develop.

@jmichelp
Copy link
Collaborator

Anyway, due to recent changes on Github, the workflow for Clippy must be adjusted for it to work properly. It now must be split into 2 workflows: an untrusted one which analyses the PR and produces a structured file with the results and a trusted one which takes this file and creates the annotations.

@gendx
Copy link
Collaborator Author

gendx commented Sep 13, 2021

Looks like the current workflow passed instead of denying the lint, so leaving this PR open until #169 is fixed.

@kaczmarczyck
Copy link
Collaborator

kaczmarczyck commented Nov 9, 2023

This PR does not work with the current CI, since crypto was excluded from clippy. I verified that CI fails when I add a let-and-return in the opensk library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants