Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chat Sample to handle unsupportedUserLocation case #95

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

andrewheard
Copy link
Collaborator

@andrewheard andrewheard commented Jan 26, 2024

Updated the ErrorDetailsView in the Chat Sample to handle the new GenerateContentError.unsupportedUserLocation case and added a Swift Preview for it.

Preview:
ErrorDetailsView Unsupported User Location Screenshot

@andrewheard andrewheard requested review from paulb777 and peterfriese and removed request for paulb777 January 26, 2024 17:19
@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Jan 26, 2024
@andrewheard andrewheard requested a review from paulb777 January 26, 2024 17:19
Copy link
Collaborator

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, just a small nit w.r.t. to phrasing.

@andrewheard andrewheard merged commit 84596eb into main Jan 26, 2024
8 checks passed
@andrewheard andrewheard deleted the ah/sample-unsupported-location branch January 26, 2024 18:22
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants