Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ErrorDetailsView in the Chat Sample to handle invalidAPIKey #94

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

andrewheard
Copy link
Collaborator

Updated the ErrorDetailsView in the Chat Sample to handle the new GenerateContentError.invalidAPIKey case and added a Swift Preview for it.

Note: This won't get triggered until #93 is merged.

Preview:
Invalid API Key ErrorDetailsView Screenshot

@andrewheard andrewheard requested a review from paulb777 January 25, 2024 21:17
@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Jan 25, 2024
@andrewheard andrewheard force-pushed the ah/sample-invalid-api-key branch from 9f0287f to 4d7219e Compare January 26, 2024 15:27
Copy link
Collaborator

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small nit about the help message.

@andrewheard andrewheard merged commit 07059df into main Jan 26, 2024
8 checks passed
@andrewheard andrewheard deleted the ah/sample-invalid-api-key branch January 26, 2024 17:09
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants