Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PartsRepresentable to throw errors #88

Merged
merged 16 commits into from
Feb 21, 2024
Merged

Allow PartsRepresentable to throw errors #88

merged 16 commits into from
Feb 21, 2024

Conversation

morganchen12
Copy link
Collaborator

@morganchen12 morganchen12 commented Jan 10, 2024

This is a breaking change. See the internal proposal for more details.

@paulb777
Copy link
Collaborator

What's an API example that will break and need to be changed?

@morganchen12
Copy link
Collaborator Author

See this file: https://github.com/google/generative-ai-swift/pull/88/files#diff-a61268065794a7fb215fc6d6e84f0127f200a881647fe588e9b06477683d4a9b

I left this PR as a draft because I think we should do some more formal API proposal before baking it in. We can discuss in standup tomorrow.

@morganchen12 morganchen12 changed the title Allow PartsRepresentable to throw errors Allow PartsRepresentable to throw errors Jan 19, 2024
@morganchen12 morganchen12 marked this pull request as ready for review January 19, 2024 22:51
@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Jan 19, 2024
Copy link
Collaborator

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions around showing how to use the updated APIs, and some remarks around naming.

@peterfriese peterfriese self-requested a review February 21, 2024 08:35
@morganchen12 morganchen12 merged commit ac4aea1 into main Feb 21, 2024
8 checks passed
@morganchen12 morganchen12 deleted the mc/error branch February 21, 2024 23:10
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants