-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extraneous apiVersion: "v1beta"
in function calling sample
#139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a bad thing to be explicit and remind people they're using a beta.
My preference would be to close. However, if you feel strongly, I'll approve.
@paulb777 I don't feel super strongly either way. My main argument in favour of removing it is to avoid overriding the defaults if not necessary since we may migrate back to |
What are the other platforms doing? |
@paulb777 Currently Dart is the only client-side SDK that offers a function calling sample. They do specify |
Dart is planning to remove the |
OK, I'm fine to merge. Thanks for checking. |
Specifying
RequestOptions(apiVersion: "v1beta")
is no longer necessary in the Function Calling sample since it is the default as of #137.