Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous apiVersion: "v1beta" in function calling sample #139

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

andrewheard
Copy link
Collaborator

Specifying RequestOptions(apiVersion: "v1beta") is no longer necessary in the Function Calling sample since it is the default as of #137.

@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Apr 19, 2024
Copy link
Collaborator

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a bad thing to be explicit and remind people they're using a beta.

My preference would be to close. However, if you feel strongly, I'll approve.

@andrewheard
Copy link
Collaborator Author

andrewheard commented Apr 19, 2024

I don't think it's a bad thing to be explicit and remind people they're using a beta.

My preference would be to close. However, if you feel strongly, I'll approve.

@paulb777 I don't feel super strongly either way. My main argument in favour of removing it is to avoid overriding the defaults if not necessary since we may migrate back to v1 in the future. Could also simplify migration to Vertex AI SDKs since we don't support overriding the apiVersion there.

@paulb777
Copy link
Collaborator

What are the other platforms doing?

@andrewheard
Copy link
Collaborator Author

What are the other platforms doing?

@paulb777 Currently Dart is the only client-side SDK that offers a function calling sample. They do specify v1beta but it only became the default today -- will ask opinions.

@andrewheard
Copy link
Collaborator Author

@paulb777
Copy link
Collaborator

OK, I'm fine to merge. Thanks for checking.

@andrewheard andrewheard merged commit d08fb28 into main Apr 19, 2024
9 checks passed
@andrewheard andrewheard deleted the ah/func-calling-sample-api-version branch April 19, 2024 20:48
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Apr 19, 2024
SsomsakTH pushed a commit to SsomsakTH/generative-ai-swift that referenced this pull request Jun 21, 2024
SsomsakTH pushed a commit to SsomsakTH/generative-ai-swift that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants