Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the migration guide. #672

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Add the migration guide. #672

merged 3 commits into from
Feb 6, 2025

Conversation

MarkDaoust
Copy link
Collaborator

No description provided.

Change-Id: I6834a1ac98f208ffad9fdedba392c25109a3d023
Change-Id: I992b94277878190aed5270adbb2b65d0f73423e6
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Feb 6, 2025
@Giom-V Giom-V requested a review from patrickloeber February 6, 2025 08:21
@Giom-V
Copy link
Contributor

Giom-V commented Feb 6, 2025

Seems OK to me, I just asked @patrickloeber for a second check

@patrickloeber
Copy link
Collaborator

After talking to @Giom-V , I think we should make it a bit more clear in the README that this SDK is deprecated. I added another PR since I didn't want to mess with @MarkDaoust PR.

The other PR basically just reorders the parts from this PR and adds an Important box. Otherwise users could not notice it and just follow the Getting Started section with the old SDK.

I added a draft PR how this could look like. Let me know what you think.

@Giom-V Giom-V merged commit d415d1a into google-gemini:main Feb 6, 2025
3 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants