Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GenerationConfig.md to fix typo #668

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

odevop
Copy link
Contributor

@odevop odevop commented Feb 1, 2025

Fixed typo in Frequency Penalty description by changing "dificult" to "difficult".

Description of the change

Fixed an unfortunate misspelling of the word "difficult". The current documentation spells the word as "dificult" (one 'f') when the correct spelling is "difficult" (two 'f').

Motivation

Implementing this change will improve the professionalism of the documentation and prevent readers from being caught off guard/distracted by the misspelling of a word.

Type of change

Documentation

Checklist

  • [ x] I have performed a self-review of my code.
  • [ x] I have added detailed comments to my code where applicable.
  • [ x] I have verified that my change does not break existing code.
  • [ x] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • [ x] I am familiar with the Google Style Guide for the language I have coded in.
  • [ x] I have read through the Contributing Guide and signed the Contributor License Agreement.

Fixed typo in Frequency Penalty description by changing "dificult" to "difficult".
Copy link

google-cla bot commented Feb 1, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Feb 1, 2025
Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR, this file Is generated from google-internal source. I'll fix that.

I'll merge this in the mean time.

@MarkDaoust MarkDaoust merged commit 56f2ccf into google-gemini:main Feb 20, 2025
4 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Feb 20, 2025
Natthachai-arm added a commit to Natthachai-arm/generative-ai-python that referenced this pull request Mar 4, 2025
Copy link

@Natthachai-arm Natthachai-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants