Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #622

Closed

Conversation

RCLDevelopers
Copy link

Just a preview really quick this code is the main initialization file for Google's Generative AI SDK it Supports both synchronous and asynchronous operations, Includes caching functionality for improved performance, Provides comprehensive model management tools, Handles both text generation and chat conversations...

Description of the change

Motivation

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other)

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

Just a preview  really quick this code is the main initialization file for Google's Generative AI SDK it Supports both synchronous and asynchronous operations, Includes caching functionality for improved performance, Provides comprehensive model management tools, Handles both text generation and chat conversations...
Copy link

google-cla bot commented Nov 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Nov 9, 2024
@MarkDaoust
Copy link
Collaborator

Comments should describe why, not what. import get_model # gets the model doesn't add any new information.

Thanks for taking the time, but I think we're going to pass on this change.

@MarkDaoust MarkDaoust closed this Nov 14, 2024
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants