-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image feedback #608
Merged
Merged
Image feedback #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmcd
previously approved these changes
Oct 29, 2024
Change-Id: I0956fb78272a8a8af2c5219d80a26dec944040a8 # Conflicts: # google/generativeai/vision_models/_vision_models.py
Change-Id: I0cac4ba1de764d3c02c5eab7556d8324aeda1f93
Change-Id: Ic5c250f3f3ded2374abfbdbee6d62ea4cfb0f799
Change-Id: I431c66e45e7582218b5de7a90eeeee01b80df664
The merge-base changed after approval.
ab19345
to
584b2ef
Compare
Change-Id: I7bfebdeaa217d93ed5d11aca31cf0b20afd38c02
Change-Id: I5c1b8cbccee0e13d8aca70582a76e0c089e040ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow generate_content to take generated images as input.
Refactor some of the image classes into the same place.
Build on
watermark
#603client.py
- Move theValue
management code to a PredictionServiceClient class.content_types.py
,image_types.py
image_types
.(Generated)Image
objects for easyImagen
->GenerateContent
. https://github.com/google-gemini/generative-ai-python/pull/608/files#diff-3e07c74e6bfc1479b6917014713aed0df6efda3eef780aa71061c0b688805b57R92-R93