Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image feedback #608

Merged
merged 12 commits into from
Nov 1, 2024
Merged

Image feedback #608

merged 12 commits into from
Nov 1, 2024

Conversation

MarkDaoust
Copy link
Collaborator

@MarkDaoust MarkDaoust commented Oct 17, 2024

Allow generate_content to take generated images as input.

Refactor some of the image classes into the same place.

Build on watermark #603

@MarkDaoust MarkDaoust marked this pull request as draft October 17, 2024 21:15
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Oct 17, 2024
@MarkDaoust MarkDaoust marked this pull request as ready for review October 24, 2024 18:53
markmcd
markmcd previously approved these changes Oct 29, 2024
Change-Id: I0956fb78272a8a8af2c5219d80a26dec944040a8

# Conflicts:
#	google/generativeai/vision_models/_vision_models.py
Change-Id: I0cac4ba1de764d3c02c5eab7556d8324aeda1f93
Change-Id: Ie7f91cef171c1f813b52ff1b2a4daedf7ea19edd
Change-Id: If9ff9ebc0b2bf16b91e741d862a9e2808c7a738a
Change-Id: Iee02352ca21fa66da9b097d4dfa9454b67609e79
Change-Id: Ic5c250f3f3ded2374abfbdbee6d62ea4cfb0f799
Change-Id: I431c66e45e7582218b5de7a90eeeee01b80df664
Change-Id: I1bb15e1363c652f9c0b4a60dad834fce65a4f0a1
@MarkDaoust MarkDaoust dismissed markmcd’s stale review October 29, 2024 18:44

The merge-base changed after approval.

Change-Id: I7bfebdeaa217d93ed5d11aca31cf0b20afd38c02
Change-Id: I5c1b8cbccee0e13d8aca70582a76e0c089e040ed
Change-Id: I2c24f8798cb8103d35474e7e6d2e4fc3100825aa
@MarkDaoust MarkDaoust merged commit c72aa6b into google-gemini:imagen Nov 1, 2024
9 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants