Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1.5 instead of 1.0 in tests #206

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Use 1.5 instead of 1.0 in tests #206

merged 1 commit into from
Jul 16, 2024

Conversation

daymxn
Copy link
Collaborator

@daymxn daymxn commented Jul 16, 2024

Per b/348216210,

This addresses some comments left in a previous PR. More specifically, it updates our tests to use 1.5 instead of 1.0 so that we better align with expected usage.

@daymxn daymxn requested a review from rlazo July 16, 2024 17:54
@daymxn daymxn self-assigned this Jul 16, 2024
@daymxn daymxn merged commit 4fbfe66 into main Jul 16, 2024
6 checks passed
@daymxn daymxn deleted the daymon-use-1.5-in-tests branch July 16, 2024 17:59
PatilShreyas pushed a commit to PatilShreyas/generative-ai-kmp that referenced this pull request Sep 21, 2024
Per [b/348216210](https://b.corp.google.com/issues/348216210),

This addresses some comments left in a previous PR. More specifically,
it updates our tests to use `1.5` instead of `1.0` so that we better
align with expected usage.
PatilShreyas pushed a commit to PatilShreyas/generative-ai-kmp that referenced this pull request Sep 21, 2024
Per [b/348216210](https://b.corp.google.com/issues/348216210),

This addresses some comments left in a previous PR. More specifically,
it updates our tests to use `1.5` instead of `1.0` so that we better
align with expected usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants