Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unity plugin] Support multielement springlength in tendons #1438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Balint-H
Copy link
Collaborator

A quick small fix for this missing feature.

Copy link

google-cla bot commented Feb 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Balint-H Balint-H force-pushed the bugfix/unity-springlength branch from 2da6bc8 to 619ca84 Compare February 23, 2024 13:55
@Balint-H Balint-H force-pushed the bugfix/unity-springlength branch from 619ca84 to 8853728 Compare February 23, 2024 14:03
@yuvaltassa
Copy link
Collaborator

yuvaltassa commented Feb 23, 2024

This LGTM but I'll let @erez-tom review.

More broadly, I propose the following easy test: Load all the models under mujoco/test/..., complain if any don't load. Would this or a similar test catch future bugs where a feature is added to MJ but is missing from the plugin? When adding a new thing, we generally always make models to test it, and they go somewhere under that directory.

@yuvaltassa yuvaltassa requested a review from erez-tom November 25, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants