credentials should be include by default

goodeggs · Apr 6, 2017 · 5457157 · 5457157
1 parent 65771df
commit 5457157
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/get_request_options/index.js b/src/get_request_options/index.js
@@ -12,7 +12,7 @@ export default function getRequestOptions (jsonFetchOptions: JsonFetchOptions):
     parsedOptions.headers['Content-Type'] = 'application/json';
   }
 
-  if (jsonFetchOptions.credentials !== undefined) {
+  if (jsonFetchOptions.credentials === undefined) {
     parsedOptions.credentials = 'include';
   }
 

diff --git a/src/get_request_options/test.js b/src/get_request_options/test.js
@@ -9,6 +9,7 @@ import getRequestOptions from '.';
 describe('getRequestOptions', async function () {
   it('populates an options object without undefined keys', function () {
     const expected = {
+      credentials: 'include',
       headers: {
         Accept: 'application/json',
       },
@@ -19,6 +20,7 @@ describe('getRequestOptions', async function () {
 
   it('sets content type header only when there is a body', function () {
     const expected = {
+      credentials: 'include',
       headers: {
         Accept: 'application/json',
         'Content-Type': 'application/json',