fix: proper azure b2c endpoint validation #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeskepetr
reviewed
Nov 1, 2024
gooddata-server-oauth2-autoconfigure/src/test/kotlin/AuthenticationUtilsTest.kt
Outdated
Show resolved
Hide resolved
Fix two issues: 1. Was sending the metadata document URI instead of issuer URI to validation function 2. Need to strip the endpoint version for proper matching Enhanced validation so it returns mismatched endpoints and their values to help when debugging. JIRA: LX-614 risk: low
chrisbonilla95
force-pushed
the
cbon-lx-614-bug-fix-and-log-enhancement
branch
from
4b38343
to
d3a4e95
Compare
jeskepetr
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two issues:
Enhanced validation so it returns mismatched endpoints and their values to help when debugging.
JIRA: LX-614
risk: low