-
Notifications
You must be signed in to change notification settings - Fork 421
refactor: move color extension to MD structure #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zkhCreator
wants to merge
1
commit into
gonzalezreal:main
Choose a base branch
from
zkhCreator:feature/resolve-conflict-color-extension
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,47 +1,49 @@ | ||
| import SwiftUI | ||
|
|
||
| extension Color { | ||
| /// Creates a constant color from an RGBA value. | ||
| /// - Parameter rgba: A 32-bit value that represents the red, green, blue, and alpha components of the color. | ||
| public init(rgba: UInt32) { | ||
| self.init( | ||
| red: CGFloat((rgba & 0xff00_0000) >> 24) / 255.0, | ||
| green: CGFloat((rgba & 0x00ff_0000) >> 16) / 255.0, | ||
| blue: CGFloat((rgba & 0x0000_ff00) >> 8) / 255.0, | ||
| opacity: CGFloat(rgba & 0x0000_00ff) / 255.0 | ||
| ) | ||
| } | ||
|
|
||
| /// Creates a context-dependent color with different values for light and dark appearances. | ||
| /// - Parameters: | ||
| /// - light: The light appearance color value. | ||
| /// - dark: The dark appearance color value. | ||
| public init(light: @escaping @autoclosure () -> Color, dark: @escaping @autoclosure () -> Color) { | ||
| #if os(watchOS) | ||
| self = dark() | ||
| #elseif canImport(UIKit) | ||
| self.init( | ||
| uiColor: .init { traitCollection in | ||
| switch traitCollection.userInterfaceStyle { | ||
| case .unspecified, .light: | ||
| return UIColor(light()) | ||
| case .dark: | ||
| return UIColor(dark()) | ||
| @unknown default: | ||
| return UIColor(light()) | ||
| } | ||
| struct MD { | ||
| /// Creates a constant color from an RGBA value. | ||
| /// - Parameter rgba: A 32-bit value that represents the red, green, blue, and alpha components of the color. | ||
| static func rgbaColor(rgba: UInt32) -> Color { | ||
| Color.init( | ||
| red: CGFloat((rgba & 0xff00_0000) >> 24) / 255.0, | ||
| green: CGFloat((rgba & 0x00ff_0000) >> 16) / 255.0, | ||
| blue: CGFloat((rgba & 0x0000_ff00) >> 8) / 255.0, | ||
| opacity: CGFloat(rgba & 0x0000_00ff) / 255.0 | ||
| ) | ||
| } | ||
| ) | ||
| #elseif canImport(AppKit) | ||
| self.init( | ||
| nsColor: .init(name: nil) { appearance in | ||
| if appearance.bestMatch(from: [.aqua, .darkAqua]) == .aqua { | ||
| return NSColor(light()) | ||
| } else { | ||
| return NSColor(dark()) | ||
| } | ||
|
|
||
| /// Creates a context-dependent color with different values for light and dark appearances. | ||
| /// - Parameters: | ||
| /// - light: The light appearance color value. | ||
| /// - dark: The dark appearance color value. | ||
| static func displayMode(light: @escaping @autoclosure () -> Color, dark: @escaping @autoclosure () -> Color) -> Color { | ||
| #if os(watchOS) | ||
| return dark() | ||
| #elseif canImport(UIKit) | ||
| return Color.init( | ||
| uiColor: .init { traitCollection in | ||
| switch traitCollection.userInterfaceStyle { | ||
| case .unspecified, .light: | ||
| return UIColor(light()) | ||
| case .dark: | ||
| return UIColor(dark()) | ||
| @unknown default: | ||
| return UIColor(light()) | ||
| } | ||
| } | ||
| ) | ||
| #elseif canImport(AppKit) | ||
| return Color.init( | ||
| nsColor: .init(name: nil) { appearance in | ||
| if appearance.bestMatch(from: [.aqua, .darkAqua]) == .aqua { | ||
| return NSColor(light()) | ||
| } else { | ||
| return NSColor(dark()) | ||
| } | ||
| } | ||
| ) | ||
| #endif | ||
| } | ||
| ) | ||
| #endif | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m noticing pervasive change of indentation from 2 to 4 spaces. For consistency (and in the interest of minimizing the change's size) the 2 space indent should be used.
Note: I’d not worry about rushing out a revision. If done, do it at your leisure. It may be some time before maintainers come through to give their review of the patch.