fix: use TARGETARCH to select the git-credential-github-app artifact #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meroje
commented
Nov 13, 2024
| @@ -44,7 +45,8 @@ RUN chmod 644 /config/config.toml | |||
| RUN apk add --update git git-lfs mercurial openssh-client subversion procps fossil tini | |||
|
|
|||
| # Add git-credential-github-app for native integration with GitHub Apps | |||
| RUN wget -O git-credential-github-app.tar.gz https://github.com/bdellegrazie/git-credential-github-app/releases/download/v0.3.0/git-credential-github-app_v0.3.0_Linux_x86_64.tar.gz \ | |||
| RUN if [ "${TARGETARCH}" = "arm64" ]; then ARCH="arm64"; else ARCH="amd64"; fi \ | |||
There was a problem hiding this comment.
@nrwiersma I'm sorry I messed up this one, should've been x86_64 in the second case
There was a problem hiding this comment.
You can open a new PR, no stress. I should have caught this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Using the new github-app credential feature on arm isn't possible as the binary is forced to be x86_64.
How is the fix applied?
Using the docker automatic TARGETARCH arg to parameterize the download
What GitHub issue(s) does this PR fix or close?
n/a