Add aad auth option when using azure storage account #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilverdewBaker
changed the title
|
Hi @matt0x6F, @nrwiersma could you please review this pr? |
|
@SilverdewBaker absolutely! Can you fill out the "how you fixed it summary? I'll start taking a look at the code but I don't have a lot of context on Azure. |
|
Taking a look at this this week; I was on vacation last week so apologies for the delayed response |
|
[heart] Yuelu Huan reacted to your message:
…________________________________
From: Matt ***@***.***>
Sent: Monday, July 8, 2024 5:35:54 PM
To: gomods/athens ***@***.***>
Cc: Yuelu Huan ***@***.***>; Mention ***@***.***>
Subject: Re: [gomods/athens] Add aad auth option when using azure storage account (PR #1973)
Taking a look at this this week; I was on vacation last week so apologies for the delayed response
—
Reply to this email directly, view it on GitHub<#1973 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANHSNJNES5UY6FKSULQWGP3ZLLEXVAVCNFSM6AAAAABKLDKQDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUG44TEMJUGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
matt0x6F
approved these changes
Jul 15, 2024
DrPsychick
referenced
this pull request
in gomods/athens-charts
Sep 14, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gomods/athens](https://redirect.github.com/gomods/athens) | minor | `v0.14.1` -> `v0.15.1` | --- ### Release Notes <details> <summary>gomods/athens (gomods/athens)</summary> ### [`v0.15.1`](https://redirect.github.com/gomods/athens/releases/tag/v0.15.1) [Compare Source](https://redirect.github.com/gomods/athens/compare/v0.15.0...v0.15.1) #### What's Changed - update-github-action(deps): bump goreleaser/goreleaser-action from 5 to 6 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/gomods/athens/pull/1969](https://redirect.github.com/gomods/athens/pull/1969) - update-github-action(deps): bump docker/build-push-action from 5 to 6 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/gomods/athens/pull/1971](https://redirect.github.com/gomods/athens/pull/1971) - Add aad auth option when using azure storage account by [@​SilverdewBaker](https://redirect.github.com/SilverdewBaker) in [https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973) - Fix helm install command in docs by [@​sb464f](https://redirect.github.com/sb464f) in [https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981) - Switch from ADAL to AzIdentity, Add Azure Storage Token Refresh, and Update Golang Version by [@​SilverdewBaker](https://redirect.github.com/SilverdewBaker) in [https://github.com/gomods/athens/pull/1977](https://redirect.github.com/gomods/athens/pull/1977) - Compatibility with proxy.golang.org for list not found responses by [@​sanyatuning](https://redirect.github.com/sanyatuning) in [https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974) - Fix: Change goreleaser flag from --rm-dist to --clean by [@​matt0x6F](https://redirect.github.com/matt0x6F) in [https://github.com/gomods/athens/pull/1984](https://redirect.github.com/gomods/athens/pull/1984) #### New Contributors - [@​SilverdewBaker](https://redirect.github.com/SilverdewBaker) made their first contribution in [https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973) - [@​sb464f](https://redirect.github.com/sb464f) made their first contribution in [https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981) - [@​sanyatuning](https://redirect.github.com/sanyatuning) made their first contribution in [https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974) **Full Changelog**: gomods/athens@v0.14.1...v0.15.1 ### [`v0.15.0`](https://redirect.github.com/gomods/athens/releases/tag/v0.15.0) [Compare Source](https://redirect.github.com/gomods/athens/compare/v0.14.1...v0.15.0) #### What's Changed - update-github-action(deps): bump goreleaser/goreleaser-action from 5 to 6 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/gomods/athens/pull/1969](https://redirect.github.com/gomods/athens/pull/1969) - update-github-action(deps): bump docker/build-push-action from 5 to 6 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/gomods/athens/pull/1971](https://redirect.github.com/gomods/athens/pull/1971) - Add aad auth option when using azure storage account by [@​SilverdewBaker](https://redirect.github.com/SilverdewBaker) in [https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973) - Fix helm install command in docs by [@​sb464f](https://redirect.github.com/sb464f) in [https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981) - Switch from ADAL to AzIdentity, Add Azure Storage Token Refresh, and Update Golang Version by [@​SilverdewBaker](https://redirect.github.com/SilverdewBaker) in [https://github.com/gomods/athens/pull/1977](https://redirect.github.com/gomods/athens/pull/1977) - Compatibility with proxy.golang.org for list not found responses by [@​sanyatuning](https://redirect.github.com/sanyatuning) in [https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974) #### New Contributors - [@​SilverdewBaker](https://redirect.github.com/SilverdewBaker) made their first contribution in [https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973) - [@​sb464f](https://redirect.github.com/sb464f) made their first contribution in [https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981) - [@​sanyatuning](https://redirect.github.com/sanyatuning) made their first contribution in [https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974) **Full Changelog**: gomods/athens@v0.14.1...v0.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/gomods/athens-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: DrPsychick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Azure blob can only be authenticated with storage account key now, this is not complaint in Microsoft, so this PR is adding a managed identity authentication option.
How is the fix applied?
Get the managed identity resource id and azure storage resource to get authentication from managed identity.
Here is the official document about managed identity usage in azure storage:
What GitHub issue(s) does this PR fix or close?
Fixes #